Skip to content

TOWER-25660: Enforce Eagle color lint with targeted exceptions - #1403

Merged
netweng merged 4 commits into
v4110-devfrom
codex/eagle-color-lint-errors
Nov 19, 2026
Merged

netweng merged 4 commits into
v4110-devfrom
codex/eagle-color-lint-errors

Conversation

@netweng

@netweng netweng commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

jira ticket

问题描述

Eagle 的硬编码颜色规则原先以 warning 报告。未加放行注释的硬编码应阻断 CI。没有完全等值 token 的历史颜色和配方需要保留原值,并在使用处说明原因。

改动

  • 将全量 Stylelint 和 ast-grep 颜色规则设为 error。旧色值用带原因、带规则名的单行注释放行。
  • 移除按 PR diff 检查等值颜色的 CI 步骤及专用脚本、测试和依赖。是否已有等值 token 由代码审查确认。
  • 精简 Stylelint 配置层,更新 check:theme 覆盖的生成文件路径。
  • CSS 文本快照采集过滤 lint 指令。保留组件原有色值、配方和既有快照。
  • 从 PR CI 移除 Chromium 安装和浏览器 computed style 检查,保留合入前手动验证的入口。

自测结果

test:colors、lint:colors 和 lint:colors:ts 均通过。验证了同一个 #00122e 未加注释时会报错,加上对应规则的行内放行指令后可通过,相邻未放行的声明仍会报错。合入前可手动运行 yarn workspace @cloudtower/eagle test:styles 比对浏览器 computed style 快照。

@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cloudtower-ui-kit Ready Ready Preview Nov 19, 2026 7:04am UTC

@netweng
netweng merged commit c9642a7 into v4110-dev Nov 19, 2026
3 checks passed
@netweng
netweng deleted the codex/eagle-color-lint-errors branch November 19, 2026 07:08

This branch was successfully deployed

1 active deployment
Preview — 644fb78c Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant